linux-kernel - Re: [PATCH] sony-laptop: constify sony_laptop_input_* and spic_attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201706242248.kIYTHHba%fengguang.wu@intel.com>
Date:   Sat, 24 Jun 2017 22:57:16 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     kbuild-all@...org, malattia@...ux.it, dvhart@...radead.org,
        andy@...radead.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sony-laptop: constify sony_laptop_input_* and
 spic_attribute_group

Hi Arvind,

[auto build test WARNING on platform-drivers-x86/for-next]
[also build test WARNING on v4.12-rc6 next-20170623]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Arvind-Yadav/sony-laptop-constify-sony_laptop_input_-and-spic_attribute_group/20170624-221228
base:   git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
config: x86_64-randconfig-x007-201725 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/platform/x86/sony-laptop.c: In function 'sony_laptop_setup_input':
>> drivers/platform/x86/sony-laptop.c:494:19: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-array-qualifiers]
     key_dev->keycode = &sony_laptop_input_keycode_map;
                      ^

vim +/const +494 drivers/platform/x86/sony-laptop.c

1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  478  	if (!key_dev) {
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  479  		error = -ENOMEM;
9593bd07 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  480  		goto err_free_kfifo;
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  481  	}
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  482  
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  483  	key_dev->name = "Sony Vaio Keys";
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  484  	key_dev->id.bustype = BUS_ISA;
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  485  	key_dev->id.vendor = PCI_VENDOR_ID_SONY;
2e4d242c drivers/misc/sony-laptop.c         Dmitry Torokhov   2007-11-21  486  	key_dev->dev.parent = &acpi_device->dev;
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  487  
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  488  	/* Initialize the Input Drivers: special keys */
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  489  	input_set_capability(key_dev, EV_MSC, MSC_SCAN);
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  490  
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  491  	__set_bit(EV_KEY, key_dev->evbit);
bc57f865 drivers/misc/sony-laptop.c         Mattia Dongili    2007-07-20  492  	key_dev->keycodesize = sizeof(sony_laptop_input_keycode_map[0]);
bc57f865 drivers/misc/sony-laptop.c         Mattia Dongili    2007-07-20  493  	key_dev->keycodemax = ARRAY_SIZE(sony_laptop_input_keycode_map);
bc57f865 drivers/misc/sony-laptop.c         Mattia Dongili    2007-07-20 @494  	key_dev->keycode = &sony_laptop_input_keycode_map;
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  495  	for (i = 0; i < ARRAY_SIZE(sony_laptop_input_keycode_map); i++)
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  496  		__set_bit(sony_laptop_input_keycode_map[i], key_dev->keybit);
c45bc9d6 drivers/platform/x86/sony-laptop.c Dmitry Torokhov   2009-12-24  497  	__clear_bit(KEY_RESERVED, key_dev->keybit);
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  498  
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  499  	error = input_register_device(key_dev);
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  500  	if (error)
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  501  		goto err_free_keydev;
1549ee6f drivers/misc/sony-laptop.c         malattia@...ux.it 2007-04-09  502  

:::::: The code at line 494 was first introduced by commit
:::::: bc57f865fa2282ad2b7efe02da0a752e602e982e sony-laptop: Make the driver use MSC_SCAN and a setkeycode and getkeycode key table.

:::::: TO: Mattia Dongili <malattia@...ux.it>
:::::: CC: Len Brown <len.brown@...el.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29885 bytes)