linux-kernel - Re: [PATCH] f2fs: avoid redundant f2fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53263f00-2bed-b547-a2b2-ceb9f9aa94ec@kernel.org>
Date:   Sat, 24 Jun 2017 22:59:44 +0800
From:   Chao Yu <chao@...nel.org>
To:     Yunlong Song <yunlong.song@...wei.com>, jaegeuk@...nel.org,
        yuchao0@...wei.com, sylinux@....com
Cc:     miaoxie@...wei.com, bintian.wang@...wei.com,
        linux-fsdevel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: avoid redundant f2fs_flush after remount

On 2017/6/24 15:57, Yunlong Song wrote:
> create_flush_cmd_control will create redundant issue_flush_thread after each
> remount with flush_merge option.
> 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,

> ---
>  fs/f2fs/segment.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index a6d7738..57f9edc 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -555,6 +555,8 @@ int create_flush_cmd_control(struct f2fs_sb_info *sbi)
>  
>  	if (SM_I(sbi)->fcc_info) {
>  		fcc = SM_I(sbi)->fcc_info;
> +		if (fcc->f2fs_issue_flush)
> +			return err;
>  		goto init_thread;
>  	}
>  
>