linux-kernel - Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627195512.v6fypt2djammkym3@ninjato>
Date:   Tue, 27 Jun 2017 21:55:12 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     robh+dt@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness

On Mon, Jun 26, 2017 at 12:44:32PM +1200, Chris Packham wrote:
> Allow devices that use this driver to be registered via a
> devicetree.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

...

> +		if (IS_ERR(i2c->gpio))
> +			return PTR_ERR(i2c->gpio);

coccicheck reported:

drivers/i2c/busses/i2c-pca-platform.c:209:3-9: ERROR: missing iounmap; ioremap on line 170 and execution via conditional on line 208

I fixed it like this (incremental diff):

-		if (IS_ERR(i2c->gpio))
-			return PTR_ERR(i2c->gpio);
+		if (IS_ERR(i2c->gpio)) {
+			ret = PTR_ERR(i2c->gpio);
+			goto e_reqirq;
+		}

and applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)