linux-kernel - Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170627195549.oosgrbgp7faxkgif@ninjato>
Date:   Tue, 27 Jun 2017 21:55:49 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     robh+dt@...nel.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

On Mon, Jun 26, 2017 at 12:44:33PM +1200, Chris Packham wrote:
> Switch to using the devm_ APIs and remove the now unnecessary error
> handling and most of the device removal code.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

And "reverted" the previous fix here:

-               if (IS_ERR(i2c->gpio)) {
-                       ret = PTR_ERR(i2c->gpio);
-                       goto e_reqirq;
-               }
+               if (IS_ERR(i2c->gpio))
+                       return PTR_ERR(i2c->gpio);

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)