lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Jun 2017 15:08:32 +0200 From: Paolo Bonzini <pbonzini@...hat.com> To: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>, kvm@...r.kernel.org Cc: linux-kernel@...r.kernel.org, borntraeger@...ibm.com, frankja@...ux.vnet.ibm.com, viro@...IV.linux.org.uk Subject: Re: [PATCH v1 1/1] KVM: add missing kvm_put_kvm in case of failure On 27/06/2017 13:57, Claudio Imbrenda wrote: > If I'm not missing anything, in case kvm_create_vm_debugfs fails, we > will have a memory leak due to not freeing the kvm object. > > A call to kvm_put_kvm was accidentally removed from an error handling in > commit 506cfba9e726 ("KVM: don't use anon_inode_getfd() before possible failures") > > This patch simply restores the call to kvm_put_kvm, so that the kvm > object is destroyed before returning an error. > > Signed-off-by: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com> > Fixes: 506cfba9e726 ("KVM: don't use anon_inode_getfd() before possible failures") > --- > virt/kvm/kvm_main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index f0fe9d0..257d2a8 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -3194,6 +3194,7 @@ static int kvm_dev_ioctl_create_vm(unsigned long type) > if (kvm_create_vm_debugfs(kvm, r) < 0) { > put_unused_fd(r); > fput(file); > + kvm_put_kvm(kvm); > return -ENOMEM; > } > > Queued, thanks. Paolo
Powered by blists - more mailing lists