linux-kernel - Re: [PATCH] KVM: Replaces symbolic permissions with numeric

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd2e5619-3a81-89cf-55a5-9380e005a50e@redhat.com>
Date:   Tue, 27 Jun 2017 15:08:55 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Roman Storozhenko <romeusmeister@...il.com>, kvm@...r.kernel.org
Cc:     rkrcmar@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: Replaces symbolic permissions with numeric



On 27/06/2017 11:51, Roman Storozhenko wrote:
> Replaces "S_IRUGO | S_IWUSR" with 0644. The reason is that symbolic
> permissions considered harmful:
> https://lwn.net/Articles/696229/
> 
> Signed-off-by: Roman Storozhenko <romeusmeister@...il.com>
> ---
>  virt/kvm/kvm_main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index f0fe9d0..3863cf7 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -73,17 +73,17 @@ MODULE_LICENSE("GPL");
>  
>  /* Architectures should define their poll value according to the halt latency */
>  unsigned int halt_poll_ns = KVM_HALT_POLL_NS_DEFAULT;
> -module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns, uint, 0644);
>  EXPORT_SYMBOL_GPL(halt_poll_ns);
>  
>  /* Default doubles per-vcpu halt_poll_ns. */
>  unsigned int halt_poll_ns_grow = 2;
> -module_param(halt_poll_ns_grow, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_grow, uint, 0644);
>  EXPORT_SYMBOL_GPL(halt_poll_ns_grow);
>  
>  /* Default resets per-vcpu halt_poll_ns . */
>  unsigned int halt_poll_ns_shrink;
> -module_param(halt_poll_ns_shrink, uint, S_IRUGO | S_IWUSR);
> +module_param(halt_poll_ns_shrink, uint, 0644);
>  EXPORT_SYMBOL_GPL(halt_poll_ns_shrink);
>  
>  /*
> 

Queued, thanks.