linux-kernel - Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628094251.vm3c36pto7p777i2@ninjato>
Date:   Wed, 28 Jun 2017 11:42:51 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Rob Herring <robh+dt@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/5] i2c: pca-platform: add devicetree awareness


> >         /* If irq is 0, we do polling. */
> > +       if (irq < 0)
> > +               irq = 0;
> 
> This does not belong to what is written in commit message. Looks like
> a separate fix.

True, this needs explanation.

> > +               of_property_read_u32_index(np, "clock-frequency", 0,
> > +                                          &i2c->algo_data.i2c_clock);
> 
> And what prevents you to use device_property_read_*() here and get rid
> of OFstuff?

device_* functions are not super much known yet. Even I tend to forget
them occasionally like here. We can fix it incrementally, too. But I
agree, it would be nice to have it right from the beginning.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)