linux-kernel - Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdykSnkyOpaAkaubnS+s32XW10ZHOYk2SRr6ORsYV7y_A@mail.gmail.com>
Date:   Wed, 28 Jun 2017 13:54:25 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Rob Herring <robh+dt@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
>
>> >         if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>> > -               ret = -ENODEV;
>> > -               goto e_adapt;
>> > +               return -ENODEV;
>>
>> This is still shadows the actual error code.
>
> Nice catch. But since it fixes a seperate issue, I'd prefer an
> incremental change here.

Agreed.

-- 
With Best Regards,
Andy Shevchenko