linux-kernel - Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26773596.thloZocoZ7@milian-kdab2>
Date:   Wed, 28 Jun 2017 11:44:48 +0200
From:   Milian Wolff <milian.wolff@...b.com>
To:     Taeung Song <treeze.taeung@...il.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...hat.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Wang Nan <wangnan0@...wei.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Kim Phillips <kim.phillips@....com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

On Wednesday, June 28, 2017 5:14:12 AM CEST Taeung Song wrote:
> Unlike asm code level, the new source code view
> provides a additional viewpoint based on source code level
> for performance analysis.
> 
> Of course, current disassembly view can show itself with pieces of source
> code but some users want to check the result of performance analysis
> based on full source code view. So add this view to the annotate TUI
> browser.
>
> Users can switch to the new source code view by a 'S' key
> and additionally support a 't' key toggling total period view.

The 't' key support should be a separate patch, I guess. It also does not 
update the column header (it stays at "Percent").

-- 
Milian Wolff | milian.wolff@...b.com | Senior Software Engineer
KDAB (Deutschland) GmbH&Co KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Download attachment "smime.p7s" of type "application/pkcs7-signature" (3826 bytes)