linux-kernel - Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 12:45:18 +0300
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     karthik@...hveda.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        sunil.m@...hveda.org
Subject: Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

Thank you Karthik,

On Wed, Jun 28, 2017 at 12:37 PM,  <karthik@...hveda.org> wrote:
> From: Karthik Tummala <karthik@...hveda.org>
>
> This patch series fixes coding style and removes the following
> checkpatch.pl warnings:
>
> Prefer using '"%s...", __func__' to using the function's name,
> in a string.

This one is good.
>
> Braces {} are not necessary for single statement blocks.

I have already sent a patch addressing this and some other things
yesterday/

>
> Rebased on top of next-20170627.
> Patches were tested and built on next-20170627

Can you please check patch 1 still applies after yesterdays patch series?

>
> Karthik Tummala (2):
>   staging: ccree: Use __func__ instead of function name
>   staging: ccree: Remove braces {} for single statement blocks
>
>  drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------
>  1 file changed, 19 insertions(+), 29 deletions(-)
>
> --
> 1.9.1
>

Thanks,
Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru