linux-kernel - Re: [PATCH] iommu/vt-d: constify intel_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 15:31:16 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     Joerg Roedel <joro@...tes.org>
Cc:     dwmw2@...radead.org, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: constify intel_dma_ops.

Hi,

Most dma_map_ops structures are never modified. Constify these
structures such that these can be write-protected. This file size diff
will show the difference between data and text segment.

Thanks,
~arvind

On Wednesday 28 June 2017 02:23 PM, Joerg Roedel wrote:
> On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote:
>> File size before:
>>     text	   data	    bss	    dec	    hex	filename
>>    32765	    758	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
>>
>> File size After adding 'const':
>>     text	   data	    bss	    dec	    hex	filename
>>    32925	    598	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
> What is the point of those commit-messages? They just show that the
> struct moved from data to the text segment. The overall size doesn't
> change much.
>
>
>
> 	Joerg
>