linux-kernel - Re: [PATCH] iommu/vt-d: constify intel_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Jun 2017 12:20:00 +0200
From:   Joerg Roedel <joro@...tes.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     dwmw2@...radead.org, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iommu/vt-d: constify intel_dma_ops.

On Wed, Jun 28, 2017 at 03:31:16PM +0530, Arvind Yadav wrote:
> Most dma_map_ops structures are never modified. Constify these
> structures such that these can be write-protected. This file size diff
> will show the difference between data and text segment.

I know what the diff shows, but it doesn't matter for this patch because
thats just an implementation detail of the compiler. The real reason for
making it 'const' is to write-protect them, and that should be clear in
the commit-message.


	Joerg