linux-kernel - Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170628120108.GA2782@katana>
Date:   Wed, 28 Jun 2017 14:01:08 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        Rob Herring <robh+dt@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 5/5] i2c: pca-platform: use dev_warn/dev_info instead
 of printk

On Wed, Jun 28, 2017 at 01:57:01PM +0300, Andy Shevchenko wrote:
> On Wed, Jun 28, 2017 at 12:37 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
> >
> >> Not a chance! Where is the commit message?
> >
> > Don't you think $subject is clear enough?
> 
> I would add the comment at least on how the output is changed since
> pr_*("%s:"..., i2c->adap.name,...)  to dev_*(&pdev->dev, ...)
> replacement.

Yes, that could have been done.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)