linux-kernel - Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451f994f23fc4ca195f577d1be302e8e@svr-chch-ex1.atlnz.lc>
Date:   Wed, 28 Jun 2017 21:03:56 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Wolfram Sang <wsa@...-dreams.de>
CC:     Rob Herring <robh+dt@...nel.org>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/5] i2c: pca-platform: use device managed allocations

On 28/06/17 22:54, Andy Shevchenko wrote:
> On Wed, Jun 28, 2017 at 12:38 PM, Wolfram Sang <wsa@...-dreams.de> wrote:
>>
>>>>          if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
>>>> -               ret = -ENODEV;
>>>> -               goto e_adapt;
>>>> +               return -ENODEV;
>>>
>>> This is still shadows the actual error code.
>>
>> Nice catch. But since it fixes a seperate issue, I'd prefer an
>> incremental change here.
> 
> Agreed.
> 

OK I can send another patch for that.