linux-kernel - Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E582614F-2B53-44BF-8E2E-000E27D510AB@cavium.com>
Date:   Wed, 28 Jun 2017 01:44:31 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>,
        Johannes Thumshirn <jthumshirn@...e.de>
CC:     Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        Hannes Reinecke <hare@...e.de>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH v2] qla2xxx: Protect access to qpair members with
 qpair->qp_lock

Hi Martin,

On 6/27/17, 6:32 PM, "Martin K. Petersen" <martin.petersen@...cle.com> wrote:

    
    > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
    > qpair->qp_lock but do access members of the qpair before having the lock.
    > Re-order the locking sequence to have all read and write access to qpair
    > members under the qpair->qp_lock.
    
    Cavium folks, please review!

I am testing it internally, will update by tomorrow. 
    
    -- 
    Martin K. Petersen	Oracle Linux Engineering
    
Thanks,
Himanshu