| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <7f88d0bd-daa8-5ab0-ae73-80432d2c791d@amd.com>
Date: Wed, 28 Jun 2017 14:39:58 -0500
From: Brijesh Singh <brijesh.singh@....com>
To: Tom Lendacky <thomas.lendacky@....com>,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: brijesh.singh@....com, gary.hook@....com,
herbert@...dor.apana.org.au, davem@...emloft.net
Subject: Re: [PATCH v2 2/3] crypto: ccp - Introduce the AMD Secure Processor
device
On 06/28/2017 12:47 PM, Tom Lendacky wrote:
>>
>> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
>> index 0528a62..418f991 100644
>> --- a/drivers/crypto/Kconfig
>> +++ b/drivers/crypto/Kconfig
>> @@ -512,14 +512,14 @@ config CRYPTO_DEV_ATMEL_SHA
>> To compile this driver as a module, choose M here: the module
>> will be called atmel-sha.
>> -config CRYPTO_DEV_CCP
>> - bool "Support for AMD Cryptographic Coprocessor"
>> +config CRYPTO_DEV_SP
>> + bool "Support for AMD Secure Processor"
>> depends on ((X86 && PCI) || (ARM64 && (OF_ADDRESS || ACPI))) && HAS_IOMEM
>> help
>> - The AMD Cryptographic Coprocessor provides hardware offload support
>> - for encryption, hashing and related operations.
>> + The AMD Secure Processor provides hardware offload support for memory
>> + encryption in virtualization and cryptographic hashing and related operations.
>> -if CRYPTO_DEV_CCP
>> +if CRYPTO_DEV_SP
>> source "drivers/crypto/ccp/Kconfig"
>> endif
>> diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
>> index 2238f77..bc08f03 100644
>> --- a/drivers/crypto/ccp/Kconfig
>> +++ b/drivers/crypto/ccp/Kconfig
>> @@ -1,26 +1,37 @@
>> -config CRYPTO_DEV_CCP_DD
>> - tristate "Cryptographic Coprocessor device driver"
>> - depends on CRYPTO_DEV_CCP
>> - default m
>> - select HW_RANDOM
>> - select DMA_ENGINE
>> - select DMADEVICES
>> - select CRYPTO_SHA1
>> - select CRYPTO_SHA256
>> - help
>> - Provides the interface to use the AMD Cryptographic Coprocessor
>> - which can be used to offload encryption operations such as SHA,
>> - AES and more. If you choose 'M' here, this module will be called
>> - ccp.
>> -
>> config CRYPTO_DEV_CCP_CRYPTO
>> tristate "Encryption and hashing offload support"
>> - depends on CRYPTO_DEV_CCP_DD
>> + depends on CRYPTO_DEV_SP_DD
>> default m
>> select CRYPTO_HASH
>> select CRYPTO_BLKCIPHER
>> select CRYPTO_AUTHENC
>> + select CRYPTO_DEV_CCP
>> help
>> Support for using the cryptographic API with the AMD Cryptographic
>> Coprocessor. This module supports offload of SHA and AES algorithms.
>> If you choose 'M' here, this module will be called ccp_crypto.
>> +
>> +config CRYPTO_DEV_SP_DD
>> + tristate "Secure Processor device driver"
>> + depends on CRYPTO_DEV_SP
>> + default m
>> + help
>> + Provides the interface to use the AMD Secure Processor. The
>> + AMD Secure Processor support the Platform Security Processor (PSP)
>> + and Cryptographic Coprocessor (CCP). If you choose 'M' here, this
>> + module will be called ccp.
>> +
>> +if CRYPTO_DEV_SP_DD
>> +config CRYPTO_DEV_CCP
>> + bool "Cryptographic Coprocessor interface"
>> + default y
>> + select HW_RANDOM
>> + select DMA_ENGINE
>> + select DMADEVICES
>> + select CRYPTO_SHA1
>> + select CRYPTO_SHA256
>> + help
>> + Provides the interface to use the AMD Cryptographic Coprocessor
>> + which can be used to offload encryption operations such as SHA,
>> + AES and more.
>> +endif
>
> I think the Kconfig changes need to be looked at a bit closer. The
> hierarchy of original version is changed and the number of entries
> might be able to be reduced.
>
Thanks Tom, how about the below patch?
In this I am leaving the top level config as-is and adding
CONFIG_CRYPTO_DEV_SP_CCP to enable the CCP device support inside the SP device driver.
[*] Support for AMD Secure Processor
<M> Secure Processor device driver
<M> Encryption and hashing offload support
-*- Cryptographic Coprocessor device
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 0528a62..148b516 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -513,11 +513,11 @@ config CRYPTO_DEV_ATMEL_SHA
will be called atmel-sha.
config CRYPTO_DEV_CCP
- bool "Support for AMD Cryptographic Coprocessor"
+ bool "Support for AMD Secure Processor"
depends on ((X86 && PCI) || (ARM64 && (OF_ADDRESS || ACPI))) && HAS_IOMEM
help
- The AMD Cryptographic Coprocessor provides hardware offload support
- for encryption, hashing and related operations.
+ The AMD Secure Processor provides hardware offload support for memory
+ encryption in virtualization and cryptographic hashing and related operations.
if CRYPTO_DEV_CCP
source "drivers/crypto/ccp/Kconfig"
diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
index 2238f77..ef3a5fb 100644
--- a/drivers/crypto/ccp/Kconfig
+++ b/drivers/crypto/ccp/Kconfig
@@ -1,26 +1,34 @@
config CRYPTO_DEV_CCP_DD
- tristate "Cryptographic Coprocessor device driver"
- depends on CRYPTO_DEV_CCP
+ tristate "Secure Processor device driver"
default m
- select HW_RANDOM
- select DMA_ENGINE
- select DMADEVICES
- select CRYPTO_SHA1
- select CRYPTO_SHA256
help
- Provides the interface to use the AMD Cryptographic Coprocessor
- which can be used to offload encryption operations such as SHA,
- AES and more. If you choose 'M' here, this module will be called
- ccp.
+ Provides AMD Secure Processor device driver.
+ If you choose 'M' here, this module will be called ccp.
+
+if CRYPTO_DEV_CCP_DD
config CRYPTO_DEV_CCP_CRYPTO
tristate "Encryption and hashing offload support"
- depends on CRYPTO_DEV_CCP_DD
default m
select CRYPTO_HASH
select CRYPTO_BLKCIPHER
select CRYPTO_AUTHENC
+ select CRYPTO_DEV_SP_CCP
help
Support for using the cryptographic API with the AMD Cryptographic
Coprocessor. This module supports offload of SHA and AES algorithms.
If you choose 'M' here, this module will be called ccp_crypto.
+
+config CRYPTO_DEV_SP_CCP
+ bool "Cryptographic Coprocessor device"
+ default y
+ select HW_RANDOM
+ select DMA_ENGINE
+ select DMADEVICES
+ select CRYPTO_SHA1
+ select CRYPTO_SHA256
+ help
+ Provides the support for AMD Cryptographic Coprocessor (CCP) device
+ which can be used to offload encryption operations such as SHA, AES
+ and more.
+endif
diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile
index 59493fd..d2f1b52 100644
--- a/drivers/crypto/ccp/Makefile
+++ b/drivers/crypto/ccp/Makefile
@@ -1,9 +1,9 @@
obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o
-ccp-objs := ccp-dev.o \
+ccp-objs := sp-dev.o ccp-platform.o
+ccp-$(CONFIG_CRYPTO_DEV_SP_CCP) += ccp-dev.o \
ccp-ops.o \
ccp-dev-v3.o \
ccp-dev-v5.o \
- ccp-platform.o \
ccp-dmaengine.o \
ccp-debugfs.o
ccp-$(CONFIG_PCI) += ccp-pci.o
Powered by blists - more mailing lists