linux-kernel - Re: [PATCH] gpiolib: fix filtering out unwanted events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda0WViPpULRAZCcBzCfCuum0GHkyWnWonS8A+LZvP+xXQ@mail.gmail.com>
Date:   Thu, 29 Jun 2017 11:33:21 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: fix filtering out unwanted events

On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski <brgl@...ev.pl> wrote:

> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>
> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
> evaluated to true even if only one event type was requested.
>
> Fix it by checking both RISING & FALLING flags explicitly.
>
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>

Patch applied for fixes.

Yours,
Linus Walleij