linux-kernel - Re: [PATCH] gpiolib: fix filtering out unwanted events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 13:03:47 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: fix filtering out unwanted events

2017-06-29 11:33 GMT+02:00 Linus Walleij <linus.walleij@...aro.org>:
> On Fri, Jun 23, 2017 at 1:45 PM, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>
>> GPIOEVENT_REQUEST_BOTH_EDGES is not a single flag, but a binary OR of
>> GPIOEVENT_REQUEST_RISING_EDGE and GPIOEVENT_REQUEST_FALLING_EDGE.
>>
>> The expression 'le->eflags & GPIOEVENT_REQUEST_BOTH_EDGES' we'll get
>> evaluated to true even if only one event type was requested.
>>
>> Fix it by checking both RISING & FALLING flags explicitly.
>>
>> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
>
> Patch applied for fixes.
>
> Yours,
> Linus Walleij

Thanks. I think this should also go to linux-stable (e.g. 4.9 LTS is
affected). Will you forward it or should I do it myself?

Thanks,
Bartosz