linux-kernel - Re: [PATCH] trace-listen: add missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170629122939.wvt632hf6tnuesf4@tarshish>
Date:   Thu, 29 Jun 2017 15:29:39 +0300
From:   Baruch Siach <baruch@...s.co.il>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace-listen: add missing header

Hi Steven,

On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> On Thu, 29 Jun 2017 14:46:21 +0300
> Baruch Siach <baruch@...s.co.il> wrote:
> 
> > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > libc:
> > 
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> >   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> >                 ^~~~~~~~
> 
> Thanks! I have a few other patches that need to go into trace-cmd. I'll
> try to get to that today or tomorrow.

There is no rush.

By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the 
same file might bite at some point. Also, MAX_PATH has different values in 
different files.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -