linux-kernel - Re: [PATCH] trace-listen: add missing header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170629085721.32d65554@gandalf.local.home>
Date:   Thu, 29 Jun 2017 08:57:21 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace-listen: add missing header

On Thu, 29 Jun 2017 15:29:39 +0300
Baruch Siach <baruch@...s.co.il> wrote:

> Hi Steven,
> 
> On Thu, Jun 29, 2017 at 08:19:56AM -0400, Steven Rostedt wrote:
> > On Thu, 29 Jun 2017 14:46:21 +0300
> > Baruch Siach <baruch@...s.co.il> wrote:
> >   
> > > The PATH_MAX macro requires the limits.h header. This fixes build with musl
> > > libc:
> > > 
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c: In function ‘make_pid_name’:
> > > .../trace-cmd-trace-cmd-v2.6.1/trace-listen.c:167:16: error: ‘PATH_MAX’ undeclared (first use in this function)
> > >   snprintf(buf, PATH_MAX, VAR_RUN_DIR "/trace-cmd-net.pid");
> > >                 ^~~~~~~~  
> > 
> > Thanks! I have a few other patches that need to go into trace-cmd. I'll
> > try to get to that today or tomorrow.  
> 
> There is no rush.
> 
> By the way, using both MAX_PATH (local) and PATH_MAX (system) macros in the 
> same file might bite at some point. Also, MAX_PATH has different values in 
> different files.

Yeah, that code should be cleaned up. It was probably me rushing to get
some feature in and not spending the time to do it nicely.

Feel free to send more patches ;-)

-- Steve