linux-kernel - [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1498741260-23676-7-git-send-email-rjdurga@gmail.com>
Date:   Thu, 29 Jun 2017 18:31:00 +0530
From:   Jaya Durga <rjdurga@...il.com>
To:     gregkh@...uxfoundation.org
Cc:     sergio.paracuellos@...il.com, juliana.orod@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Jaya Durga <rjdurga@...il.com>, Jaya Durga <jayad@...c.in>
Subject: [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is  usually wrong

Fix checkpatch.pl issue
WARNING: Use of volatile is usually wrong:
see Documentation/process/volatile-considered-harmful.rst

The variables in the private data that are
marked volatile don't need to be. Remove the volatile.

Signed-off-by: Jaya Durga <jayad@...c.in>
---
 drivers/staging/wlan-ng/hfa384x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 310e2c4..015945f 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
 	enum ctlx_state state;	/* Tracks running state */
 
 	struct completion done;
-	volatile int reapable;	/* Food for the reaper task */
+	int reapable;	/* Food for the reaper task */
 
 	ctlx_cmdcb_t cmdcb;	/* Async command callback */
 	ctlx_usercb_t usercb;	/* Async user callback, */
-- 
1.9.1