linux-kernel - Re: [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1498742557.8633.12.camel@perches.com>
Date:   Thu, 29 Jun 2017 06:22:37 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jaya Durga <rjdurga@...il.com>, gregkh@...uxfoundation.org
Cc:     sergio.paracuellos@...il.com, juliana.orod@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Jaya Durga <jayad@...c.in>
Subject: Re: [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile
 is  usually wrong

On Thu, 2017-06-29 at 18:31 +0530, Jaya Durga wrote:
> Fix checkpatch.pl issue
> WARNING: Use of volatile is usually wrong:
> see Documentation/process/volatile-considered-harmful.rst
> 
> The variables in the private data that are
> marked volatile don't need to be. Remove the volatile.

If you examine the code that uses reapable,
it appears reapable should not be an int
but instead should be an enum cmd_mode.

> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
[]
> @@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
>  	enum ctlx_state state;	/* Tracks running state */
>  
>  	struct completion done;
> -	volatile int reapable;	/* Food for the reaper task */
> +	int reapable;	/* Food for the reaper task */
>  
>  	ctlx_cmdcb_t cmdcb;	/* Async command callback */
>  	ctlx_usercb_t usercb;	/* Async user callback, */