linux-kernel - Re: [PATCH v2] hwmon: Add LTC2471/LTC2473 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Jun 2017 08:08:00 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mike Looijmans <mike.looijmans@...ic.nl>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, jdelvare@...e.com,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v2] hwmon: Add LTC2471/LTC2473 driver

On Thu, Jun 29, 2017 at 04:11:42PM +0200, Mike Looijmans wrote:
> On 29-06-17 15:40, Guenter Roeck wrote:
> >On 06/29/2017 05:30 AM, Lars-Peter Clausen wrote:
> >>On 06/29/2017 02:13 PM, Mike Looijmans wrote:
> >>>The LTC2741 and LTC2473 are single voltage monitoring chips. The LTC2473
> >>>is similar to the LTC2471 but outputs a signed differential value.
> >>>
> >>>Datasheet:
> >>>   http://cds.linear.com/docs/en/datasheet/24713fb.pdf
> >>
> >>This looks more like a general purpose ADC rather than a specialized voltage
> >>monitoring chip. In my opinion this driver would be better suited for the
> >>IIO framework. But before you start working on that lets try to hear what
> >>others think about this.
> >>
> >
> >Agreed (I just replied to that on another thread).
> 
> Took a peek at the IIO drivers, looks simple enough, so I suggest to drop
> this patch and I'll create an IIO driver instead.
> 
> The ltc2485 (as suggested by Guenter on that other thread) is pretty similar
> indeed, it might be feasible to join the two and have one driver handle them
> both. That would be preferred over a separat driver, right?
> 
In general yes, but it really depends on the similarities and differences. If
the single driver ends up twice as large, it is probably better to keep them
separate. If all you need to do is to add chip IDs, obviously a single driver
is better. Everything in between really depends on the amount of chip specific
code.

Thanks,
Guenter