linux-kernel - Re: [PATCH v2] hwmon: Add LTC2471/LTC2473 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63b1e076-38e8-c276-8518-d8c9d7abb1b7@metafoo.de>
Date:   Thu, 29 Jun 2017 17:30:22 +0200
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Mike Looijmans <mike.looijmans@...ic.nl>,
        Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, jdelvare@...e.com,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v2] hwmon: Add LTC2471/LTC2473 driver

On 06/29/2017 04:11 PM, Mike Looijmans wrote:
> On 29-06-17 15:40, Guenter Roeck wrote:
>> On 06/29/2017 05:30 AM, Lars-Peter Clausen wrote:
>>> On 06/29/2017 02:13 PM, Mike Looijmans wrote:
>>>> The LTC2741 and LTC2473 are single voltage monitoring chips. The LTC2473
>>>> is similar to the LTC2471 but outputs a signed differential value.
>>>>
>>>> Datasheet:
>>>>    http://cds.linear.com/docs/en/datasheet/24713fb.pdf
>>>
>>> This looks more like a general purpose ADC rather than a specialized voltage
>>> monitoring chip. In my opinion this driver would be better suited for the
>>> IIO framework. But before you start working on that lets try to hear what
>>> others think about this.
>>>
>>
>> Agreed (I just replied to that on another thread).
> 
> Took a peek at the IIO drivers, looks simple enough, so I suggest to drop
> this patch and I'll create an IIO driver instead.
> 
> The ltc2485 (as suggested by Guenter on that other thread) is pretty similar
> indeed, it might be feasible to join the two and have one driver handle them
> both. That would be preferred over a separat driver, right?
> 

I think the ltc2485 is close enough. It's even listed in the datasheet as a
related part. The main difference seems to be the resolution of the ADC and
the extra temperature sensor channel.

Although one thing to consider is that their control/mode register is quite
different. But the current driver doesn't write it.