[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5h1sq2g3z7.wl-tiwai@suse.de>
Date: Thu, 29 Jun 2017 18:20:44 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Arvind Yadav" <arvind.yadav.cs@...il.com>
Cc: <perex@...ex.cz>, <alsa-devel@...a-project.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda: constify attribute_group structures.
On Thu, 29 Jun 2017 12:37:01 +0200,
Arvind Yadav wrote:
>
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/device.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 995 608 0 1603 643 sound/pci/hda/hda_sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1035 544 0 1579 62b sound/pci/hda/hda_sysfs.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Applied, thanks.
Takashi
Powered by blists - more mailing lists