linux-kernel - Re: [PATCH] ALSA: pcm: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h37aig3zh.wl-tiwai@suse.de>
Date:   Thu, 29 Jun 2017 18:20:34 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arvind Yadav" <arvind.yadav.cs@...il.com>
Cc:     <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: pcm: constify attribute_group structures.

On Thu, 29 Jun 2017 12:32:56 +0200,
Arvind Yadav wrote:
> 
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/device.h> work with const
> attribute_group. So mark the non-const structs as const.
> 
> File size before:
>    text	   data	    bss	    dec	    hex	filename
>    9781	    240	      8	  10029	   272d	sound/core/pcm.o
> 
> File size After adding 'const':
>    text	   data	    bss	    dec	    hex	filename
>    9813	    176	      8	   9997	   270d	sound/core/pcm.o
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Applied, thanks.


Takashi