linux-kernel - Re: [PATCH 5/6] i2c: pca-platform: use device_property_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170630090354.6s6ahpjhis7ptbfg@ninjato>
Date:   Fri, 30 Jun 2017 11:03:55 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Chris Packham <chris.packham@...iedtelesis.co.nz>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Linux-SH <linux-sh@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] i2c: pca-platform: use device_property_read_u32


> > -               i2c->algo_data.i2c_clock = 59000;
> > +               ret = device_property_read_u32(&pdev->dev, "clock-frequency",
> > +                                              &i2c->algo_data.i2c_clock);
> > +               if (ret)
> > +                       i2c->algo_data.i2c_clock = 59000;
> 
> My idea is to get rid of legacy platform data completely.
> That's why I suggested device_* in the first place.
> 
> In similar way like you did with GPIO lookup table, you may use
> PROPERTY_ENTRY*() macros in the board files.
> 
> Does it make sense?

Frankly, I am not a big fan of converting board files if we cannot test
the changes.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)