linux-kernel - Re: [PATCH] staging: ks7010: fix styling WARNINGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170630183927.GA13036@ubuntulaptop>
Date:   Fri, 30 Jun 2017 11:39:27 -0700
From:   Mark Rogers <mail@...k-rogers.org>
To:     Frans Klaver <fransklaver@...il.com>
Cc:     gregkh@...uxfoundation.org, me@...in.cc, karniksayli1995@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs

Thank you for your feedback. I guess when making this patch I had the
preferred coding style in mind, but didn't ask myself if making the code
conform to it would truly improve readability.

I agree with all of your comments. Do you think the best course of
action is to create a new patch with this change alone and forget the
rest?

-       DPRINTK(1, "ks7010_sdio_remove()\n");
+       DPRINTK(1, "%s()\n", __func__);

Sorry about the newbie questions and bad patch, I will do better with
the next one. Thanks again for your time and feedback, I really
appreciate it.

Mark