linux-kernel - Re: [PATCH] staging: ks7010: fix styling WARNINGs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2017 19:27:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mark Rogers <mail@...k-rogers.org>
Cc:     Frans Klaver <fransklaver@...il.com>, devel@...verdev.osuosl.org,
        karniksayli1995@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ks7010: fix styling WARNINGs

On Fri, Jun 30, 2017 at 11:39:27AM -0700, Mark Rogers wrote:
> Thank you for your feedback. I guess when making this patch I had the
> preferred coding style in mind, but didn't ask myself if making the code
> conform to it would truly improve readability.
> 
> I agree with all of your comments. Do you think the best course of
> action is to create a new patch with this change alone and forget the
> rest?
> 
> -       DPRINTK(1, "ks7010_sdio_remove()\n");
> +       DPRINTK(1, "%s()\n", __func__);

Lines like this, that are just "here I am!" comments, should all be
deleted anyway, we have ftrace in the kernel, people always seem to
forget about it...

thanks,

greg k-h