linux-kernel - Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbc9fcd5-e57a-780e-4618-d9c6a19d7433@cogentembedded.com>
Date:   Sat, 1 Jul 2017 00:09:43 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Tejun Heo <tj@...nel.org>
Cc:     linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar_probe()

On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote:

> platform_get_irq() returns an error code, but the sata_rcar driver
> ignores it and always returns -EINVAL. This is not correct, and
> prevents -EPROBE_DEFER from being propagated properly. Also,
> notice that platform_get_irq() no longer returns 0 on error.
>
> Print error message and propagate the return value of platform_get_irq
> on failure.
>
> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

    You forgot to collect:

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

MBR, Sergei