linux-kernel - Re: [PATCH v2] sata_rcar: fix error return code in sata_rcar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Jun 2017 16:11:56 -0500
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     Tejun Heo <tj@...nel.org>, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sata_rcar: fix error return code in
 sata_rcar_probe()


Quoting Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:

> On 07/01/2017 12:08 AM, Gustavo A. R. Silva wrote:
>
>> platform_get_irq() returns an error code, but the sata_rcar driver
>> ignores it and always returns -EINVAL. This is not correct, and
>> prevents -EPROBE_DEFER from being propagated properly. Also,
>> notice that platform_get_irq() no longer returns 0 on error.
>>
>> Print error message and propagate the return value of platform_get_irq
>> on failure.
>>
>> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>
>    You forgot to collect:
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
>

Oh I'm sorry. Should I send v3?

Thanks
--
Gustavo A. R. Silva