linux-kernel - Re: [PATCH] ASoC: imx-ssi: add check on platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170701045140.GA9664@Asurada>
Date:   Fri, 30 Jun 2017 21:51:41 -0700
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Timur Tabi <timur@...i.org>, Xiubo Li <Xiubo.Lee@...il.com>,
        Fabio Estevam <fabio.estevam@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: imx-ssi: add check on platform_get_irq return value

On Fri, Jun 30, 2017 at 05:17:35PM -0500, Gustavo A. R. Silva wrote:
> Check return value from call to platform_get_irq(),
> so in case of failure print error message and propagate
> the return value.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>

Acked-by: Nicolin Chen <nicoleotsuka@...il.com>

Thanks

> ---
>  sound/soc/fsl/imx-ssi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
> index b95132e..0679061 100644
> --- a/sound/soc/fsl/imx-ssi.c
> +++ b/sound/soc/fsl/imx-ssi.c
> @@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
>  	}
>  
>  	ssi->irq = platform_get_irq(pdev, 0);
> +	if (ssi->irq < 0) {
> +		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
> +		return ssi->irq;
> +	}
>  
>  	ssi->clk = devm_clk_get(&pdev->dev, NULL);
>  	if (IS_ERR(ssi->clk)) {
> -- 
> 2.5.0
>