linux-kernel - Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ0PZbRfrz0-pp318Z1rQOXMkQvCQX3ju__CC7Obzsyp91VtpA@mail.gmail.com>
Date:   Sat, 1 Jul 2017 16:42:29 +0900
From:   MyungJoo Ham <myungjoo.ham@...sung.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>
Cc:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        Kyungmin Park <kyungmin.park@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Linux PM list <linux-pm@...r.kernel.org>,
        linux-tegra@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] devfreq: tegra: fix error code in tegra_devfreq_probe()

On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@...sung.com> wrote:
> Hi,
>
> On 2017년 06월 30일 16:22, Gustavo A. R. Silva wrote:
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>>  drivers/devfreq/tegra-devfreq.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>> index 214fff9..ae71215 100644
>> --- a/drivers/devfreq/tegra-devfreq.c
>> +++ b/drivers/devfreq/tegra-devfreq.c
>> @@ -688,9 +688,9 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>>       }
>>
>>       irq = platform_get_irq(pdev, 0);
>> -     if (irq <= 0) {
>> -             dev_err(&pdev->dev, "Failed to get IRQ\n");
>> -             return -ENODEV;
>> +     if (irq < 0) {
>> +             dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
>> +             return irq;
>>       }
>>
>>       platform_set_drvdata(pdev, tegra);
>>
>
> Reviewed-by: Chanwoo Choi <cw00.choi@...sung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>

>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics



-- 
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics