linux-kernel - Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170701074804.GB85052@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Sat, 1 Jul 2017 00:48:04 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <chao@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs

On 06/29, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> Don't clear old mount option before parse new option during ->remount_fs
> like other generic filesystems.

So, what happened on your original patch?

commit 26666c8a4366debae30ae37d0688b2bec92d196a
    f2fs: fix to clean previous mount option when remount_fs

I think we need to rever the original patch tho.

Thanks,

> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/super.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index f27c141cd8aa..af472f7968d0 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data)
>  			clear_sbi_flag(sbi, SBI_NEED_SB_WRITE);
>  	}
>  
> -	sbi->mount_opt.opt = 0;
>  	default_options(sbi);
>  
>  	/* parse mount options */
> -- 
> 2.13.0.90.g1eb437020