linux-kernel - Re: [PATCH] libnvdimm, region, pmem: fix 'badblocks' sysfs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1499023372.2042.1.camel@hpe.com>
Date:   Sun, 2 Jul 2017 19:31:49 +0000
From:   "Kani, Toshimitsu" <toshi.kani@....com>
To:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] libnvdimm, region, pmem: fix 'badblocks'
 sysfs_get_dirent() reference lifetime

On Sat, 2017-07-01 at 08:50 -0700, Dan Williams wrote:
> We need to hold a reference on the 'dirent' until we are sure there
> are no more notifications that will be sent. As noted in the new
> comments we take advantage of the fact that the references are taken
> and dropped under device_lock() and that nd_device_notify() holds
> device_lock() over new badblocks notifications. The notifications
> that happen when badblocks are cleared only occur while the device is
> active.
> 
> Also take the opportunity to fix up the error messages to report the
> user visible effect of a sysfs_get_dirent() failure.
> 
> Fixes: 975750a98c26 ("libnvdimm, pmem: Add sysfs notifications to
> badblocks")
> Cc: Toshi Kani <toshi.kani@....com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Reviewed-by: Toshi Kani <toshi.kani@....com>

Thanks Dan!
-Toshi