linux-kernel - Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAExDi1TTV+RL3EygpCzVU-ZxtyUL061_1Bz0vsj97iUuUGe9Bg@mail.gmail.com>
Date:   Sun, 2 Jul 2017 21:38:52 +0200
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Janusz Lisiecki <janusz.lisiecki@...il.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Driver Project Developer List 
        <driverdev-devel@...uxdriverproject.org>,
        devel@...verdev.osuosl.org,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] staging: ks7010: Fix cast to restricted __le16 in ks_wlan_net.c

On Sun, Jul 2, 2017 at 4:27 PM, Janusz Lisiecki
<janusz.lisiecki@...il.com> wrote:
> This patch fixes the following Sparse warnings in ks_wlan_net.c:
> drivers/staging/ks7010/ks_wlan_net.c:1359:24: warning: cast to restricted __le16
> Both sides of assignment are u16 so (as 'ap' is local_ap_t type and 'capability' member,
> have the same as local 'capabilities' type of u16) 'le16_to_cpu' is not needed

It could be that it's ap->capability's type that is wrong (not
annotated with __le16).
Isn't it?

Is ap->capability supposed to hold a little-endian value or a native
order value?

-- Luc