linux-kernel - Re: [PATCH] drm: radeon: radeon_ttm: constify ttm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e1a1fa4-b0f2-ce05-8125-de27ffcc2bd8@vodafone.de>
Date:   Sun, 2 Jul 2017 14:44:18 +0200
From:   Christian König <deathsimple@...afone.de>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        alexander.deucher@....com, christian.koenig@....com,
        airlied@...ux.ie, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: radeon: radeon_ttm: constify ttm_place structures.

Am 02.07.2017 um 11:06 schrieb Arvind Yadav:
> ttm_place are not supposed to change at runtime. All functions
> working with ttm_place provided by <drm/ttm/ttm_placement.h> work
> with const ttm_place. So mark the non-const structs as const.
>
> File size before:
>     text	   data	    bss	    dec	    hex	filename
>     9235	    344	    136	   9715	   25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> File size After adding 'const':
>     text	   data	    bss	    dec	    hex	filename
>     9267	    312	    136	   9715	   25f3 drivers/gpu/drm/radeon/radeon_ttm.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 8b7623b..6499832 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -178,7 +178,7 @@ static int radeon_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
>   static void radeon_evict_flags(struct ttm_buffer_object *bo,
>   				struct ttm_placement *placement)
>   {
> -	static struct ttm_place placements = {
> +	static const struct ttm_place placements = {
>   		.fpfn = 0,
>   		.lpfn = 0,
>   		.flags = TTM_PL_MASK_CACHING | TTM_PL_FLAG_SYSTEM