linux-kernel - Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1707021543590.2296@nanos>
Date:   Sun, 2 Jul 2017 15:46:04 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Vikas Shivappa <vikas.shivappa@...ux.intel.com>
cc:     x86@...nel.org, linux-kernel@...r.kernel.org, hpa@...or.com,
        peterz@...radead.org, ravi.v.shankar@...el.com,
        vikas.shivappa@...el.com, tony.luck@...el.com,
        fenghua.yu@...el.com, andi.kleen@...el.com
Subject: Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events
 (total and local)

On Mon, 26 Jun 2017, Vikas Shivappa wrote:
> +static struct mon_evt mbm_total_event = {
> +	.name = "mbm_total_bytes",
> +	.evtid = QOS_L3_MBM_TOTAL_EVENT_ID,
> +};
> +
> +static struct mon_evt mbm_local_event = {
> +	.name = "mbm_local_bytes",
> +	.evtid = QOS_L3_MBM_LOCAL_EVENT_ID,
> +};
> +
>  static void l3_mon_evt_init(struct rdt_resource *r)
>  {
>  	INIT_LIST_HEAD(&r->evt_list);
>  
>  	if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID))
>  		list_add_tail(&llc_occupancy_event.list, &r->evt_list);
> +	if (is_mbm_total_enabled())
> +		list_add_tail(&mbm_total_event.list, &r->evt_list);
> +	if (is_mbm_local_enabled())
> +		list_add_tail(&mbm_local_event.list, &r->evt_list);

Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why?

Thanks,

	tglx