linux-kernel - Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt delivery modes setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <39f90dc4-ad69-71a7-f746-d0c71f4a5898@cn.fujitsu.com>
Date:   Mon, 3 Jul 2017 14:47:43 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <mingo@...nel.org>,
        <hpa@...or.com>, <ebiederm@...ssion.com>, <bhe@...hat.com>,
        <boris.ostrovsky@...cle.com>, <peterz@...radead.org>,
        <izumi.taku@...fujitsu.com>
Subject: Re: [PATCH v5 02/12] x86/apic: Prepare for unifying the interrupt
 delivery modes setup

Hi Thomas,

At 07/03/2017 02:41 PM, Thomas Gleixner wrote:
> On Mon, 3 Jul 2017, Dou Liyang wrote:
>> At 07/03/2017 01:47 AM, Thomas Gleixner wrote:
>>> On Fri, 30 Jun 2017, Dou Liyang wrote:
>>>> +/* Init the interrupt delivery mode for the BSP */
>>>> +void __init apic_intr_mode_init(void)
>>>> +{
>>>> +	switch (apic_intr_mode_select()) {
>>>> +	case APIC_PIC:
>>>> +		apic_printk(APIC_VERBOSE, KERN_INFO
>>>> +			"Keep in PIC mode(8259)\n");
>>>
>>> Please do not proliferate that APIC_VERBOSE, KERN_INFO mess. Clean up the
>>> apic_printk() macro first. Either change printk() to pr_info() or make the
>>> printk level dependent on the APIC verbosity.
>>
>> Oops, I understood, How about the following:
>>
>> pr_info("APIC: keep in PIC mode(8259)\n");
>
> As this is once per boot, it's ok to have that information unconditionally
> printed.

Yes, I see.  will change others in the next version.

Thanks,

	dou.
>
> Thanks,
>
> 	tglx
>
>
>