linux-kernel - Re: [PATCH v5 10/12] x86/xen: Bypass intr mode setup in enlighten

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3548720-714c-4199-b8d2-f6db29804ed9@cn.fujitsu.com>
Date:   Mon, 3 Jul 2017 11:53:01 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     <x86@...nel.org>, <linux-kernel@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <mingo@...nel.org>,
        <hpa@...or.com>, <ebiederm@...ssion.com>, <bhe@...hat.com>,
        <boris.ostrovsky@...cle.com>, <peterz@...radead.org>,
        <izumi.taku@...fujitsu.com>
Subject: Re: [PATCH v5 10/12] x86/xen: Bypass intr mode setup in enlighten_pv
 system

Hi Thomas,

At 07/03/2017 03:18 AM, Thomas Gleixner wrote:
> On Fri, 30 Jun 2017, Dou Liyang wrote:
>
>> xen_smp_ops overwrites smp_prepare_cpus to xen_pv_smp_prepare_cpus
>> which initializes interrupt itself.
>>
>> Touching the intr_mode_init causes unexpected results on the system.
>>
>> Bypass it in enlighten_pv system.
>
> So that's the wrong patch order then. You broke XEN at some point with your
> changes. You need to prevent that breakage upfront not after the fact.

Yes, I have considered to prevent that breakage in the patchset.

Actually, Until the 11th patch, we put the intr_mode_init ahead of
time, which will break XEN.

Before the 11th patch, we just unify the code and do the preparation,
Kernel will do the intr_mode_init like before, which will have no
influence on XEN.

So we put the patch here before 11th patch.

Thanks,

	dou.

>
> Thanks,
>
> 	tglx
>
>
>