linux-kernel - Re: [PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=MccOquh9ovQTLB-F2GiQND3EQXmcKDEqh26o+RY470UZw@mail.gmail.com>
Date:   Tue, 4 Jul 2017 16:27:08 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: skip unwanted events, don't convert them to
 opposite edge

2017-07-03 13:07 GMT+02:00 Andy Shevchenko <andy.shevchenko@...il.com>:
> On Mon, Jul 3, 2017 at 12:12 PM, Bartosz Golaszewski <brgl@...ev.pl> wrote:
>> The previous fix for filtering out of unwatched events was not entirely
>> correct. Instead of skipping the events we don't want, they are now
>> interpreted as events with opposing edge.
>>
>> In order to fix it: always read the GPIO line value on interrupt and
>> only emit the event if it corresponds with the event type we requested.
>
>>         struct lineevent_state *le = p;
>>         struct gpioevent_data ge;
>> -       int ret;
>> +       int ret, level;
>
> I prefer
> int level;
> int ret;
>
> Though it's matter of taste (I don't remember which one Linus' preferable).
>
> --
> With Best Regards,
> Andy Shevchenko

Hard to tell, the file uses both styles.

Thanks,
Bartosz