linux-kernel - Re: [PATCH] gpiolib: skip unwanted events, don't convert them to opposite edge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZF4H9gH8B9FDTv8cBUocFWfbEppO=hXWMrTgfRBE0zSw@mail.gmail.com>
Date:   Tue, 1 Aug 2017 14:08:25 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: skip unwanted events, don't convert them to
 opposite edge

On Mon, Jul 3, 2017 at 11:12 AM, Bartosz Golaszewski <brgl@...ev.pl> wrote:

> The previous fix for filtering out of unwatched events was not entirely
> correct. Instead of skipping the events we don't want, they are now
> interpreted as events with opposing edge.
>
> In order to fix it: always read the GPIO line value on interrupt and
> only emit the event if it corresponds with the event type we requested.
>
> Fixes: ad537b822577 ("gpiolib: fix filtering out unwanted events")
> Signed-off-by: Bartosz Golaszewski <brgl@...ev.pl>
> ---
> Hi Linus,
>
> I tested my previous fix on a real board, where I got a storm of
> interrupts from simply playing with a GPIO manually. It looked ok so I
> posted the patch, but I didn't notice that when waiting for rising-edge
> events, all falling-edge events got interpreted as such. This patch
> should actually fix this bug. Tested carefully with gpio-mockup this
> time.

Patrch applied for fixes and tagged for stable.

Yours,
Linus Walleij