linux-kernel - Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATRrngmVFPDSKmUm3Td7RXnSZSPGNF9Ds_y+DU=i7mRag@mail.gmail.com>
Date:   Wed, 5 Jul 2017 00:43:08 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     William Breathitt Gray <vilhelm.gray@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
Cc:     linux-gpio@...r.kernel.org,
        Grygorii Strashko <grygorii.strashko@...com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ray Jui <rjui@...adcom.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        David Cohen <david.a.cohen@...ux.intel.com>,
        Scott Branden <sbranden@...adcom.com>,
        linux-acpi@...r.kernel.org,
        Broadcom Kernel Feedback List 
        <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Alexander Shiyan <shc_work@...l.ru>,
        Michal Simek <michal.simek@...inx.com>,
        Kevin Hilman <khilman@...nel.org>, linux-tegra@...r.kernel.org,
        Joel Stanley <joel@....id.au>, linux-omap@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        patches@...nsource.cirrus.com, Alban Bedel <albeu@...e.fr>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Tien Hock Loh <thloh@...era.com>
Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h

2017-07-04 21:58 GMT+09:00 William Breathitt Gray <vilhelm.gray@...il.com>:
> On Tue, Jul 04, 2017 at 12:53:34PM +0900, Masahiro Yamada wrote:
>>Some of include directives in include/linux/gpio/driver.h are
>>unneeded because the header does not need to know the content of
>>struct device, irq_chip, etc.  Just declare they are structures.
>>
>>On the other hand, <linux/irqhandler.h> and <linux/spinlock_types.h>
>>turned out to be necessary for irq_flow_handler_t and spinlock_t,
>>respectively.
>>
>>Each driver should include what it needs without relying on what is
>>implicitly included from <linux/gpio/driver.h>.  This will cut down
>>unnecessary header parsing.
>>
>>Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>---
>>
>> drivers/gpio/gpio-104-dio-48e.c  |  1 +
>> drivers/gpio/gpio-104-idi-48.c   |  1 +
>> drivers/gpio/gpio-104-idio-16.c  |  1 +
>> drivers/gpio/gpio-pci-idio-16.c  |  2 ++
>> drivers/gpio/gpio-ws16c48.c      |  1 +
>
> The changes to the above drivers look fine to me:
>
> Acked-by: William Breathitt Gray <vilhelm.gray@...il.com>
>
> However, this patch as a whole does too many things; I'd like to see it
> split-up logically similar to how Andy Shevchenko suggested in his
> reply. That should allow ACKs by respective driver maintainers to be
> accounted more properly.
>
> William Breathitt Gray


I was missing a very important thing.

<linux/gpio/driver.h> is used in various subsystems.

I tested only under drivers/gpio/, but
drivers/pinctrl/ is one of the biggest source of compile errors.

(Probably I will get reports from kbuild test robot.)


So, I need to think about how to merge this (if the basic idea of this is OK).

Maybe,

[1] Send patches to subsystems (gpio, pinctrl, etc.) for v4.14
[2] Drop unneeded includes from linux/gpio/driver.h for v4.15


-- 
Best Regards
Masahiro Yamada