linux-kernel - Re: [PATCH] integrity: get rid of unneeded initializations in integrity_iint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170706150424.GA21489@mail.hallyn.com>
Date:   Thu, 6 Jul 2017 10:04:24 -0500
From:   "Serge E. Hallyn" <serge@...lyn.com>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        "Serge E. Hallyn" <serge@...lyn.com>, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH] integrity: get rid of unneeded initializations in
 integrity_iint_cache entries

Quoting Jeff Layton (jlayton@...nel.org):
> From: Jeff Layton <jlayton@...hat.com>
> 
> The init_once routine memsets the whole object to 0, and then
> explicitly sets some of the fields to 0 again. Just remove the explicit
> initializations.
> 
> Signed-off-by: Jeff Layton <jlayton@...hat.com>

Reviewed-by: Serge Hallyn <serge@...lyn.com>

> ---
>  security/integrity/iint.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/security/integrity/iint.c b/security/integrity/iint.c
> index 6fc888ca468e..187b7cb378be 100644
> --- a/security/integrity/iint.c
> +++ b/security/integrity/iint.c
> @@ -153,14 +153,11 @@ static void init_once(void *foo)
>  	struct integrity_iint_cache *iint = foo;
>  
>  	memset(iint, 0, sizeof(*iint));
> -	iint->version = 0;
> -	iint->flags = 0UL;
>  	iint->ima_file_status = INTEGRITY_UNKNOWN;
>  	iint->ima_mmap_status = INTEGRITY_UNKNOWN;
>  	iint->ima_bprm_status = INTEGRITY_UNKNOWN;
>  	iint->ima_read_status = INTEGRITY_UNKNOWN;
>  	iint->evm_status = INTEGRITY_UNKNOWN;
> -	iint->measured_pcrs = 0;
>  }
>  
>  static int __init integrity_iintcache_init(void)
> -- 
> 2.13.0