linux-kernel - Re: [git pull] vfs.git part 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170706150330.GQ10672@ZenIV.linux.org.uk>
Date:   Thu, 6 Jul 2017 16:03:30 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Christoph Hellwig <hch@....de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] vfs.git part 3

On Thu, Jul 06, 2017 at 04:48:40PM +0200, Christoph Hellwig wrote:

> Just did the whole batch (patch below), but it seems like using a
> __bitwise type in SYSCALL_DEFINE* will always give warnings like:
> 
> fs/read_write.c:1095:1: warning: cast to restricted __kernel_rwf_t
> 
> which I'm not sure to deal with..

#define __SC_CAST(t, a) (__force t) a

in syscalls.h

> index a2d4a8ac94ca..a04adbc70ddf 100644
> --- a/include/uapi/linux/aio_abi.h
> +++ b/include/uapi/linux/aio_abi.h
> @@ -28,6 +28,7 @@
>  #define __LINUX__AIO_ABI_H
>  
>  #include <linux/types.h>
> +#include <linux/fs.h>

Um...  Includes of non-uapi in uapi are wrong.  What do you need
fs.h for, anyway?  Just put the typedef into uapi/linux/types.h
and be done with that...

> +#define	BLK_STS_OK 0
> +#define BLK_STS_NOTSUPP		((__force blk_status_t)1)
> +#define BLK_STS_TIMEOUT		((__force blk_status_t)2)
> +#define BLK_STS_NOSPC		((__force blk_status_t)3)
> +#define BLK_STS_TRANSPORT	((__force blk_status_t)4)
> +#define BLK_STS_TARGET		((__force blk_status_t)5)
> +#define BLK_STS_NEXUS		((__force blk_status_t)6)

WTF is that doing here?  If nothing else, it's a userland namespace
pollution; typedefs with such names are OK in the kernel, but not
is something that might be included from userland.  And that chunk
doesn't seem to have anything to do with the rest of the patch...

Please, move that on top of current #work.read_write - there's
a fix for buggered vfs_write_iter() in it.