linux-kernel - Re: [PATCH] regmap: regmap-w1: Fix build troubles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170710131717.grpaai4wjync6g6w@earth>
Date:   Mon, 10 Jul 2017 15:17:17 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Mark Brown <broonie@...nel.org>
Cc:     "Alex A. Mihaylov" <minimumlaw@...bler.ru>,
        Evgeniy Polyakov <zbr@...emap.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: regmap-w1: Fix build troubles

Hi,

On Mon, Jul 10, 2017 at 01:19:35PM +0100, Mark Brown wrote:
> On Mon, Jul 10, 2017 at 01:51:38PM +0200, Sebastian Reichel wrote:
> > > Patches like this *really* shouldn't be appearing during the merge
> > > window, they should be being handled well before that with everything
> > > ready in -next when the merge window opens.
> 
> > Both patches were in linux-next and both patches have been pulled
> > by Linus. This is broken *now*.
> 
> Why are none of the build bots finding problems if this is currently
> broken and why did this not get fixed in -next when it was introduced?

I guess it is because at the moment nothing select REGMAP_W1 in
mainline. I did not (yet) queue the power-supply driver, which
was the initial reason for adding regmap w1 support.

> Like I say I provided a tag for this and didn't get any request to
> pull/apply the update in the other direction so it is extremely
> disappointing to see that the header move went ahead after that without
> the regmap support being included and someone else is having to come
> along and clean up the mess.

FWIW I am just the messenger, who actually pointed out the issue
_before_ it happened in the threads of both patchsets. I expected
this to be properly solved by you and Greg. Since this did not
work out regmap seems now the logical subsystem for the fix.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)