linux-kernel - Re: [PATCH v2] staging: ccree: Use __func_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOtvUMerfaZj8zzooUM0Kvn0qntGo8RR3rRUH_UZz70wyL-orA@mail.gmail.com>
Date:   Tue, 11 Jul 2017 16:40:03 +0300
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     karthik@...hveda.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>,
        sunil.m@...hveda.org
Subject: Re: [PATCH v2] staging: ccree: Use __func__ instead of function name

Hello Karthik ,

Thank you for the patch.

On Thu, Jun 29, 2017 at 8:08 PM,  <karthik@...hveda.org> wrote:
> From: Karthik Tummala <karthik@...hveda.org>
>
> Fixed following checkpatch.pl warning:
>         WARNING: Prefer using '"%s...", __func__' to using
> the function's name, in a string
>
> It is prefered to use '%s & __func__' instead of function
> name for logging.
>
> Signed-off-by: Karthik Tummala <karthik@...hveda.org>
> ---
> Changes for v2:
> v1 was a patch series, which consisted of two patches in which
> second one was already submitted by Gilad Ben-Yossef, so dropped
> that one.
>
> Patch generated on staging-testing as suggested by Greg-K H.
> ---
>  drivers/staging/ccree/ssi_aead.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_aead.c b/drivers/staging/ccree/ssi_aead.c
> index 1fc0b05..1168161 100644
> --- a/drivers/staging/ccree/ssi_aead.c
> +++ b/drivers/staging/ccree/ssi_aead.c
> @@ -1886,7 +1886,7 @@ static int config_gcm_context(struct aead_request *req)
>                                 (req->cryptlen - ctx->authsize);
>         __be32 counter = cpu_to_be32(2);
>
> -       SSI_LOG_DEBUG("config_gcm_context() cryptlen = %d, req->assoclen = %d ctx->authsize = %d\n", cryptlen, req->assoclen, ctx->authsize);
> +       SSI_LOG_DEBUG("%s() cryptlen = %d, req->assoclen = %d ctx->authsize = %d\n", __func__, cryptlen, req->assoclen, ctx->authsize);
>
>         memset(req_ctx->hkey, 0, AES_BLOCK_SIZE);
>
> @@ -2198,7 +2198,7 @@ static int ssi_rfc4106_gcm_setkey(struct crypto_aead *tfm, const u8 *key, unsign
>         struct ssi_aead_ctx *ctx = crypto_aead_ctx(tfm);
>         int rc = 0;
>
> -       SSI_LOG_DEBUG("ssi_rfc4106_gcm_setkey()  keylen %d, key %p\n", keylen, key);
> +       SSI_LOG_DEBUG("%s()  keylen %d, key %p\n", __func__, keylen, key);
>
>         if (keylen < 4)
>                 return -EINVAL;
> @@ -2216,7 +2216,7 @@ static int ssi_rfc4543_gcm_setkey(struct crypto_aead *tfm, const u8 *key, unsign
>         struct ssi_aead_ctx *ctx = crypto_aead_ctx(tfm);
>         int rc = 0;
>
> -       SSI_LOG_DEBUG("ssi_rfc4543_gcm_setkey()  keylen %d, key %p\n", keylen, key);
> +       SSI_LOG_DEBUG("%s()  keylen %d, key %p\n", __func__, keylen, key);
>
>         if (keylen < 4)
>                 return -EINVAL;
> --
> 1.9.1
>

Acked-by: Gilad Ben-Yossef <gilad@...yossef.com>

Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
 -- Jean-Baptiste Queru