linux-kernel - Re: [PATCH v2 1/2] Staging: android/ion: fix sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH6sp9NM-HJgikPcz8HuDMKO4zt925E_ZhMmuzZMm6CmQBKmqA@mail.gmail.com>
Date:   Wed, 12 Jul 2017 07:22:04 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     Joseph Wright <rjosephwright@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, arve@...roid.com,
        riandrews@...roid.com, driverdevel <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] Staging: android/ion: fix sparse warnings

Hi,

please consider changing your subject to something like

staging: android/ion: declare two functions

Perhaps you can make it more on-topic. It's more useful than "fix
sparse warning"

On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright <rjosephwright@...il.com> wrote:
> Declare functions to fix sparse warnings:
>
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
>         was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
>         was not declared. Should it be static?

And then explain why declaring them is preferred over making them static.

Frans