linux-kernel - Re: [PATCH v2 2/2] Staging: android/ion: fix sparse warning

Open Source and information security mailing list archives

Message-ID: <CAH6sp9O0hedahRL-hDUKgr2pi1X9eT_Ko9rg8TUZ8y1uAq6_Xw@mail.gmail.com>
Date:   Wed, 12 Jul 2017 07:23:47 +0200
From:   Frans Klaver <fransklaver@...il.com>
To:     Joseph Wright <rjosephwright@...il.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, arve@...roid.com,
        riandrews@...roid.com, driverdevel <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] Staging: android/ion: fix sparse warning

Hi,

Again, your subject is too generic.

On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright <rjosephwright@...il.com> wrote:
> Declare private function static to fix sparse warning:
>
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
>         was not declared. Should it be static?
>
> Signed-off-by: Joseph Wright <rjosephwright@...il.com>
> ---
> Changes in v2:
>   - Split into multiple patches
>
>  drivers/staging/android/ion/ion_cma_heap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index a0949bc..c6db9b7 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
>         return &cma_heap->heap;
>  }
>
> -int __ion_add_cma_heaps(struct cma *cma, void *data)
> +static int __ion_add_cma_heaps(struct cma *cma, void *data)
>  {
>         struct ion_heap *heap;
>
> --
> 2.9.3
>
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives