linux-kernel - Re: [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1959612.ejQZU5VTTY@aspire.rjw.lan>
Date:   Wed, 12 Jul 2017 23:17:53 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Lv Zheng <lv.zheng@...el.com>
Cc:     "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Len Brown <len.brown@...el.com>, Lv Zheng <zetalog@...il.com>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        Stable # all applicable <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression

On Wednesday, July 12, 2017 11:09:09 AM Lv Zheng wrote:
> According to the bug report, though the busy polling mode can make noirq
> stages executed faster, it causes abnormal fan blowing up after a system
> resume (see link #1 for a video demonstration) on Lenovo ThinkPad X1 Carbon
>  - the 5th Generation. The problem can be fixed by an upgraded EC firmware.
> 
> However many reporters can also confirm that the problem can be fixed by
> stopping busy polling during suspend/resume.
> 
> This patch drops noirq stage hooks so that the regression can be fixed
> without upgrading the EC firmware.
> 
> Fixes: c3a696b6e8f8 ("ACPI / EC: Use busy polling mode when GPE is not enabled")
> Link: https://youtu.be/9NQ9x-Jm99Q                       [#1]
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129
> Reported-by: Andreas Lindhe <andreas@...dhe.io>
> Tested-by: Gjorgji Jankovski <j.gjorgji@...il.com>
> Tested-by: Damjan Georgievski <gdamjan@...il.com>
> Tested-by: Fernando Chaves <nanochaves@...il.com>
> Tested-by: Tomislav Ivek <tomislav.ivek@...il.com>
> Tested-by: Denis P. <theoriginal.skullburner@...il.com>
> Signed-off-by: Lv Zheng <lv.zheng@...el.com>
> Cc: Stable <stable@...r.kernel.org> # all applicable

Both patches applied with some minor modifications in the changelogs.

Thanks,
Rafael